Drop dev deps redundant with policyengine-core (#920)#1695
Open
vahid-ahmadi wants to merge 2 commits into
Open
Drop dev deps redundant with policyengine-core (#920)#1695vahid-ahmadi wants to merge 2 commits into
vahid-ahmadi wants to merge 2 commits into
Conversation
policyengine-core already pulls in pytest and wheel as runtime deps and ruff, coverage, pytest-cov and towncrier through its dev extras, so listing them again here only adds maintenance overhead. Mirrors the pattern in the US package (policyengine-us#4859).
The previous commit removed these on the assumption that policyengine-core would bring them in. That was wrong: they're in core's *dev* extras, and pip does NOT install extras-of-dependencies transitively. CI broke with "pytest: error: unrecognized arguments: --cov=..." because pytest-cov wasn't installed. What core actually brings in transitively (runtime deps): - pytest<9,>=8 - wheel<1 So pytest and wheel can stay removed; the other four need to come back. Updated the comment in pyproject.toml to be explicit about the extras-not-installed-transitively rule, and corrected the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine-corealready supplies —pytestandwheelride along as core runtime deps;ruff,coverage,pytest-covandtowncrierare in core's own dev extras with at-least-as-tight constraints.furo<2023,tqdm,setuptools,sphinx-argparse,sphinx-math-dollar,snowballstemmer,jupyter-book>=2.0.0a0,rich) in place since core either doesn't ship them or ships incompatible major versions (e.g.jupyter-book<1vs the v2 alpha UK uses).microdf-python>=1.2.1,pydantic>=2.11.7andtablesdirectly because their version requirements diverge from core or aren't in core at all.Test plan
pip install -e ".[dev]"resolves cleanly.ruff,pytest,towncrierremain on PATH transitively.python -m pytest policyengine_uk/tests/microsimulation/test_abolish_council_tax_reform.py -vpasses.🤖 Generated with Claude Code